Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix --disable-single-executable-application #51808

Closed
wants to merge 1 commit into from
Closed

src: fix --disable-single-executable-application #51808

wants to merge 1 commit into from

Commits on Feb 19, 2024

  1. src: fix --disable-single-executable-application 

    Previously it would not compile if the build is configured with
--disable-single-executable-application because we use directives
to exclude the definition of SEA-related code completely. This patch
changes them so that the SEA code are still compiled and internals
can still check whether the executable is an SEA. The executable would
not try to load the SEA blob at all if SEA is disabled. If future
modifications to the C++ code attempt to load the SEA blob when SEA
is disabled, UNREACHABLE() would be raised. If user attempt to
generate the SEA blob with --experimental-sea-config with an executable
that disables SEA, they would get an error.
    @joyeecheung
    joyeecheung committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7b07c8f View commit details
    Browse the repository at this point in the history