Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-child-process-fork-net #51841

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions test/parallel/test-child-process-fork-net.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

// This tests that a socket sent to the forked process works.
// See https://github.com/nodejs/node/commit/dceebbfa

'use strict';
const {
mustCall,
Expand Down Expand Up @@ -65,7 +68,7 @@ if (process.argv[2] === 'child') {
socket.on('finish', mustCall(() => {
debug(`[${id}] socket finished ${m}`);
}));
}));
}, 4));

process.on('message', mustCall((m) => {
if (m !== 'close') return;
Expand All @@ -74,7 +77,7 @@ if (process.argv[2] === 'child') {
debug(`[${id}] ending ${i}/${needEnd.length}`);
endMe.end('end');
});
}));
}, 4));

process.on('disconnect', mustCall(() => {
debug(`[${id}] process disconnect, ending`);
Expand Down Expand Up @@ -146,9 +149,22 @@ if (process.argv[2] === 'child') {
server.on('close', mustCall(function() {
closeEmitted = true;

child1.kill();
child2.kill();
child3.kill();
// Clean up child processes.
try {
child1.kill();
} catch {
debug('child process already terminated');
}
try {
child2.kill();
} catch {
debug('child process already terminated');
}
try {
child3.kill();
} catch {
debug('child process already terminated');
}
}));

server.listen(0, '127.0.0.1');
Expand Down