Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: un-set test-emit-after-on-destroyed as flaky #51995

Merged
merged 1 commit into from
Mar 8, 2024
Merged

test: un-set test-emit-after-on-destroyed as flaky #51995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: un-set test-emit-after-on-destroyed as flaky 
I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: #50245 (comment)
  • Loading branch information
@abmusse
abmusse committed Mar 6, 2024
commit cf778ddaa0f659f14c098db3ac210e813eb31b1a
2 changes: 0 additions & 2 deletions test/async-hooks/async-hooks.status
View file
Original file line number Diff line number Diff line change
@@ -21,5 +21,3 @@ test-callback-error: PASS, FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/issues/50245
test-emit-after-on-destroyed: PASS, FLAKY