Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix detect-module not retrying as ESM for code that errors only in CommonJS #52024

Merged
merged 8 commits into from
Mar 12, 2024
Merged

module: fix detect-module not retrying as ESM for code that errors only in CommonJS #52024

merged 8 commits into from
Mar 12, 2024

Commits on Mar 11, 2024

  1. module: fix detect-module not retrying as esm for cjs-only errors

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f44c31c View commit details
    Browse the repository at this point in the history

  2. fix tla above import/export

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b28976c View commit details
    Browse the repository at this point in the history

  3. add test for redeclaration above import/export

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9114338 View commit details
    Browse the repository at this point in the history

  4. add double declaration test case

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7f99f57 View commit details
    Browse the repository at this point in the history

  5. don't check second error message set unnecessarily

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ecd8096 View commit details
    Browse the repository at this point in the history

  6. update docs

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b1c17bb View commit details
    Browse the repository at this point in the history

  7. lint

    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    026d6c1 View commit details
    Browse the repository at this point in the history

  8. use plain async function wrapper instead of CommonJS module wrapper a… 

    …round async function wrapper; add test
    @GeoffreyBooth
    GeoffreyBooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    228f5c7 View commit details
    Browse the repository at this point in the history