Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch: mark as stable #52074

Merged
merged 1 commit into from
Mar 15, 2024
+9 −4
Merged

watch: mark as stable #52074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,14 +2302,17 @@ added:
- v18.11.0
- v16.19.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/52074
description: Watch mode is now stable.
- version:
- v19.2.0
- v18.13.0
pr-url: https://github.com/nodejs/node/pull/45214
description: Test runner now supports running in watch mode.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
Starts Node.js in watch mode.
When in watch mode, changes in the watched files cause the Node.js process to
Expand All @@ -2331,9 +2334,13 @@ node --watch index.js
added:
- v18.11.0
- v16.19.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/52074

This comment was marked as spam.

Sign in to view

description: Watch mode is now stable.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
Starts Node.js in watch mode and specifies what paths to watch.
When in watch mode, changes in the watched paths cause the Node.js process to
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/main/watch_mode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const {
exitCodes: { kNoFailure },
} = internalBinding('errors');
const { getOptionValue } = require('internal/options');
const { emitExperimentalWarning } = require('internal/util');
const { FilesWatcher } = require('internal/watch_mode/files_watcher');
const { green, blue, red, white, clear } = require('internal/util/colors');

Expand Down Expand Up @@ -117,7 +116,6 @@ async function restart() {
}
}

emitExperimentalWarning('Watch mode');
start();
watcher
.on('changed', restart)
Expand Down