Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: don't await the same promise for each test #52185

Closed
wants to merge 2 commits into from
Closed

test_runner: don't await the same promise for each test #52185

wants to merge 2 commits into from

Commits on Mar 22, 2024

  1. test: fix incorrect test fixture 

    This commit updates a test runner fixture that includes a failing
child test. However, the nested test is created using the top
level test() function instead t.test(). This commit updates the
fixture to use t.test(), while preserving the expected failure.

Refs: nodejs#47164
    @cjihrig
    cjihrig committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b7d0808 View commit details
    Browse the repository at this point in the history

  2. test_runner: don't await the same promise for each test 

    Prior to this commit, each top level test awaited the same
global promise for setting up test reporters. This commit
updates the logic to only await the promise the first time
it is encountered.
    @cjihrig
    cjihrig committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ed1821a View commit details
    Browse the repository at this point in the history