Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: apply null as this for util.format #5222

Closed
wants to merge 1 commit into from
Closed

console: apply null as this for util.format #5222

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

the util.format just a stateless function. apply current console
as this is unnecessary.

@JacksonTian
console: apply null as this for util.format
0b31fc3 
the util.format just a stateless function. apply current console
as `this` is unnecessary.
@JacksonTian JacksonTian changed the title console: apply null as this for util.format` console: apply null as this for util.format Feb 14, 2016
@silverwind silverwind added the console Issues and PRs related to the console subsystem. label Feb 14, 2016
@jasnell
Copy link
Member

jasnell commented Feb 15, 2016

LGTM

@silverwind
Copy link
Contributor

LGTM, CI: https://ci.nodejs.org/job/node-test-pull-request/1694/

@targos
Copy link
Member

targos commented Feb 18, 2016

LGTM

targos pushed a commit that referenced this pull request Feb 18, 2016
@JacksonTian @targos
console: apply null as this for util.format
0903b6d 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: #5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@targos
Copy link
Member

targos commented Feb 18, 2016

Landed in 0903b6d

@targos targos closed this Feb 18, 2016
rvagg pushed a commit that referenced this pull request Feb 21, 2016
@JacksonTian @rvagg
console: apply null as this for util.format
df93d60 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: #5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@JacksonTian JacksonTian deleted the apply_null branch February 22, 2016 08:16
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@JacksonTian
console: apply null as this for util.format
2665f94 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: #5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@JacksonTian
console: apply null as this for util.format
de4c07b 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: #5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@JacksonTian
console: apply null as this for util.format
78ddd9b 
Util.format is just a stateless function. Apply current console
as `this` is unnecessary.

PR-URL: #5222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacksonTian @jasnell @silverwind @targos @MylesBorins