http: fix http-parser regression (v4.x) #5238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @thealphanerd @rvagg ... this will need to go into v4.3.1 |
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) is header
jasnell
force-pushed
the
fix-http-parser-regression-v4.x
branch
from
5f14f3f
to
fa6571c
Compare
|
LGTM |
|
Only failure is infra related |
|
LGTM |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 15, 2016
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) is header PR-URL: #5238 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
|
Landed as 188cff3 |
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 16, 2016
Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - nodejs#4738 * debugger: guard against call from non-node context (Ben Noordhuis) - nodejs#4328 * node_contextify: do not incept debug context (Myles Borins) - nodejs#4819 * deps: update to http-parser 2.5.2 (James Snell) - nodejs#5238
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Notable changes: * buffer: make byteLength work with Buffer correctly (Jackson Tian) - #4738 * debugger: guard against call from non-node context (Ben Noordhuis) - #4328 * node_contextify: do not incept debug context (Myles Borins) - #4819 * deps: update to http-parser 2.5.2 (James Snell) - #5238 PR-URL: #5200 (comment)
|
This might help someone else, but this was the cause of a bunch of mystery nginx "upstream prematurely closed connection while reading response header from upstream" when proxying to node on v4.3.0. The proxied request bails so early that it appears nothing happens from the node side. You can bind to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new IS_HEADER_CHAR check in http-parser is improperly
checking char when it should be checking unsigned char.
/cc @ChALkeR