Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove line breaks in markdown definitions #52490

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 12, 2024

A line break in a definition ends the definition, causing an error with upcoming changes to the linter and possibly other tools.

This (or some other change) is needed for
nodejs/remark-preset-lint-node#511.

Refs: nodejs/remark-preset-lint-node#511

A line break in a definition ends the definition, causing an error with
upcoming changes to the linter and possibly other tools.

This (or some other change) is needed for
nodejs/remark-preset-lint-node#511.

Refs: nodejs/remark-preset-lint-node#511
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 12, 2024
@Trott
Copy link
Member Author

Trott commented Apr 12, 2024

Whoops, guess I should have run "make lint-md" with the current linter before doing this. Odd that the new linter didn't flag it, but maybe the more strict definition line-break rule was coupled with a more lenient line length rule for definitinos? Anyway....will fix....

@Trott
Copy link
Member Author

Trott commented Apr 12, 2024

Aw crud, the GitHub-flavored markdown spec (or whatever you want to call it) specifically says that titles can be muti-line so this seems like it might be a bug in the new remark lint plugin.

It's supposed to be a link definition, so I wonder if the way we're using it (without links) is the problem. More investigating to do....

EDIT: Ref: https://github.github.com/gfm/#link-reference-definitions

@Trott
Copy link
Member Author

Trott commented Apr 12, 2024

Oh, here we go, GFM considers these things footnotes and not link definitions, so the new plugin probably needs a bugfix.

https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/

@Trott
Copy link
Member Author

Trott commented Apr 12, 2024

Looks like the plugin doesn't understand multi-line footnotes. Or at least that's what I think is going on. I'm going to close this and pursue changes in the plugin or configuration or something like that. Thanks.

@Trott Trott closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants