fixup! enforce multiline

nodejs · nodejs-github-bot · Apr 21, 2024 · Apr 19, 2024 · Apr 19, 2024 · Apr 19, 2024
commit f340dc51ccb37f9d9afe5b78076bdc8c6769efb8
diff --git a/lib/internal/bootstrap/switches/is_main_thread.js b/lib/internal/bootstrap/switches/is_main_thread.js
@@ -1,6 +1,9 @@
 'use strict';
 
-const { ObjectDefineProperty } = primordials;
+const {
+  ObjectDefineProperty,
+} = primordials;
+
 const rawMethods = internalBinding('process_methods');
 const {
   namespace: {

diff --git a/lib/internal/bootstrap/switches/is_not_main_thread.js b/lib/internal/bootstrap/switches/is_not_main_thread.js
@@ -1,6 +1,8 @@
 'use strict';
 
-const { ObjectDefineProperty } = primordials;
+const {
+  ObjectDefineProperty,
+} = primordials;
 
 delete process._debugProcess;
 delete process._debugEnd;

diff --git a/lib/internal/cluster/shared_handle.js b/lib/internal/cluster/shared_handle.js
@@ -1,5 +1,9 @@
 'use strict';
-const { SafeMap } = primordials;
+
+const {
+  SafeMap,
+} = primordials;
+
 const assert = require('internal/assert');
 const dgram = require('internal/dgram');
 const net = require('net');

diff --git a/lib/internal/error_serdes.js b/lib/internal/error_serdes.js
@@ -28,7 +28,7 @@ const {
   URIError,
 } = primordials;
 
-const Buffer = require('buffer').Buffer;
+const { Buffer } = require('buffer');
 const { inspect: { custom: customInspectSymbol } } = require('util');
 
 const kSerializedError = 0;

diff --git a/lib/internal/main/run_main_module.js b/lib/internal/main/run_main_module.js
@@ -1,6 +1,8 @@
 'use strict';
 
-const { RegExpPrototypeExec } = primordials;
+const {
+  RegExpPrototypeExec,
+} = primordials;
 
 const {
   prepareMainThreadExecution,

diff --git a/lib/internal/modules/esm/formats.js b/lib/internal/modules/esm/formats.js
@@ -1,6 +1,9 @@
 'use strict';
 
-const { RegExpPrototypeExec } = primordials;
+const {
+  RegExpPrototypeExec,
+} = primordials;
+
 const { getOptionValue } = require('internal/options');
 const { getValidatedPath } = require('internal/fs/utils');
 const pathModule = require('path');

diff --git a/lib/internal/modules/esm/initialize_import_meta.js b/lib/internal/modules/esm/initialize_import_meta.js
@@ -1,6 +1,9 @@
 'use strict';
 
-const { StringPrototypeStartsWith } = primordials;
+const {
+  StringPrototypeStartsWith,
+} = primordials;
+
 const { getOptionValue } = require('internal/options');
 const { fileURLToPath } = require('internal/url');
 const { dirname } = require('path');

diff --git a/lib/internal/test_runner/reporter/dot.js b/lib/internal/test_runner/reporter/dot.js
@@ -1,5 +1,8 @@
 'use strict';
-const { MathMax } = primordials;
+
+const {
+  MathMax,
+} = primordials;
 
 module.exports = async function* dot(source) {
   let count = 0;

diff --git a/lib/test.js b/lib/test.js
@@ -1,5 +1,10 @@
 'use strict';
-const { ObjectAssign, ObjectDefineProperty } = primordials;
+
+const {
+  ObjectAssign,
+  ObjectDefineProperty,
+} = primordials;
+
 const { test, suite, before, after, beforeEach, afterEach } = require('internal/test_runner/harness');
 const { run } = require('internal/test_runner/runner');
 

diff --git a/lib/test/reporters.js b/lib/test/reporters.js
@@ -1,6 +1,9 @@
 'use strict';
 
-const { ObjectDefineProperties, ReflectConstruct } = primordials;
+const {
+  ObjectDefineProperties,
+  ReflectConstruct,
+} = primordials;
 
 let dot;
 let junit;

diff --git a/test/parallel/test-eslint-alphabetize-primordials.js b/test/parallel/test-eslint-alphabetize-primordials.js
 'use strict';

 const common = require('../common');
 if ((!common.hasCrypto) || (!common.hasIntl)) {
	'use strict';
Check failure on line 1 in test/parallel/test-eslint-alphabetize-primordials.js GitHub Actions / test-macOS --- stderr --- /Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:458 throw err; ^ AssertionError [ERR_ASSERTION]: Should have 1 error but had 2: [ { ruleId: 'alphabetize-primordials', severity: 1, message: 'destructuring from primordials should be multiline', line: 1, column: 45, nodeType: 'ObjectPattern', endLine: 1, endColumn: 52 }, { ruleId: 'alphabetize-primordials', severity: 1, message: 'destructuring from primordials should be the first expression after "use strict"', line: 1, column: 45, nodeType: 'VariableDeclarator', endLine: 1, endColumn: 66 } ] at testInvalidTemplate (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:965:24) at RuleTester.<anonymous> (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1194:33) at RuleTester.itDefaultHandler (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:453:23) at /Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1191:73 at Array.forEach (<anonymous>) at RuleTester.<anonymous> (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1190:34) at RuleTester.describeDefaultHandler (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:470:19) at RuleTester.<anonymous> (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1189:34) at RuleTester.describeDefaultHandler (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:470:19) at RuleTester.run (/Users/runner/work/node/node/tools/node_modules/eslint/lib/rule-tester/rule-tester.js:1174:26) { generatedMessage: false, code: 'ERR_ASSERTION', actual: 2, expected: 1, operator: 'strictEqual' } Node.js v22.0.0-pre Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-eslint-alphabetize-primordials.js

	const common = require('../common');
	if ((!common.hasCrypto) \|\| (!common.hasIntl)) {