Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: address recent coverity warnings #52647

Closed
wants to merge 1 commit into from
Closed

quic: address recent coverity warnings #52647

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

No description provided.

@mhdawson
quic: address recent coverity warnings
907846c 
Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Apr 22, 2024
@mhdawson
Copy link
Member Author

This is an example of the recent warnings that showed up:

85QuicError QuicError::ForTransport(error_code code, std::string reason) {
     	1. move: reason is moved (indicated by std::move(reason)).
286  QuicError error(std::move(reason));
     	
CID 362781: (#1 of 1): Using a moved object (USE_AFTER_MOVE)
2. use_after_move: reason is used after it has been already moved.
287  ngtcp2_ccerr_set_transport_error(
288      &error.error_, code, error.reason_c_str(), reason.length());
289  return error;
290}

@mhdawson
Copy link
Member Author

@nodejs/quic FYI

vmoroz
vmoroz approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoroz
Copy link
Member

vmoroz commented Apr 22, 2024

Currently quic cctest is failing on Windows. Hopefully this PR must fix them.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58641/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58702/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58750/

mhdawson added a commit that referenced this pull request Apr 29, 2024
@mhdawson
quic: address recent coverity warnings
d2ebaaa 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member Author

Landed in d2ebaaa

@mhdawson mhdawson closed this Apr 29, 2024
aduh95 pushed a commit that referenced this pull request Apr 30, 2024
@mhdawson @aduh95
quic: address recent coverity warnings
d086ab4 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@mhdawson @Ch3nYuY
quic: address recent coverity warnings
cf255c5 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolito marco-ippolito added backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels May 21, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@mhdawson @eliphazbouye
quic: address recent coverity warnings
a929407 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@mhdawson @bmeck
quic: address recent coverity warnings
12b2d97 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@vmoroz vmoroz vmoroz approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @vmoroz @nodejs-github-bot @jasnell @mertcanaltin @marco-ippolito