Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: harmonize Clang checks and update V8 warning cflags #52873

Closed
wants to merge 2 commits into from
Closed

build: harmonize Clang checks and update V8 warning cflags #52873

wants to merge 2 commits into from

Commits on May 7, 2024

  1. build: harmonize Clang checks 

    - Set the clang variable in `config.gypi` so it depends on compiler
  checks made by the configure script.
- Replace gyp conditions with `llvm_version` and "0.0" with conditions
  that use the `clang` variable.
- Always use `clang==1` or `clang==0` in gyp conditions
    @targos
    targos committed May 7, 2024
    Configuration menu
    Copy the full SHA
    791b8ff View commit details
    Browse the repository at this point in the history

  2. build: sync V8 warning cflags with BUILD.gn

    @targos
    targos committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3c2feaa View commit details
    Browse the repository at this point in the history