lib: speed up MessageEvent creation internally #52951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
KhafraDev
force-pushed
the
use-fast-create-messageevent
branch
from
98377de
to
43aa76e
Compare
KhafraDev
changed the title
|
Benchmarks look great: |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
anonrig
reviewed
May 12, 2024
benjamingr
approved these changes
May 13, 2024
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/52951 ✔ Done loading data for nodejs/node/pull/52951 ----------------------------------- PR info ------------------------------------ Title lib: speed up MessageEvent creation internally (#52951) Author Khafra (@KhafraDev) Branch KhafraDev:use-fast-create-messageevent -> nodejs:main Labels author ready, worker, needs-ci Commits 2 - lib: speed up MessageEvent creation internally - fixup Committers 1 - Khafra PR-URL: https://github.com/nodejs/node/pull/52951 Refs: https://github.com/nodejs/undici/pull/3170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52951 Refs: https://github.com/nodejs/undici/pull/3170 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 May 2024 02:53:03 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52951#pullrequestreview-2052434926 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52951#pullrequestreview-2071390736 ✔ Last GitHub CI successful ℹ Last Benchmark CI on 2024-05-12T06:53:30Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1561/ ℹ Last Full PR CI on 2024-05-30T16:17:26Z: https://ci.nodejs.org/job/node-test-pull-request/59542/ - Querying data for job/node-test-pull-request/59542/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52951 From https://github.com/nodejs/node * branch refs/pull/52951/merge -> FETCH_HEAD ✔ Fetched commits as 75fe4f35d4e5..29c44f31e535 -------------------------------------------------------------------------------- [main bac899986b] lib: speed up MessageEvent creation internally Author: Khafra Date: Sat May 11 22:49:27 2024 -0400 1 file changed, 6 insertions(+), 5 deletions(-) [main 849a35ded2] fixup Author: Khafra Date: Mon May 13 01:47:55 2024 -0400 1 file changed, 2 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9532972963 |
nodejs-github-bot
added
the
commit-queue-failed
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 672e4cc |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #52951 Refs: nodejs/undici#3170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52951 Refs: nodejs/undici#3170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52951 Refs: nodejs/undici#3170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createFastMessageEventcan be used when the arguments passed to the MessageEvent constructor do not need to be validated.Refs: nodejs/undici#3170
Refs: #52370 (review)