doc: improve for httpVersionMajor & httpVersionMinor #5296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of httpVersionMarjor & httpVersionMinor should have same context like httpVersion.
mscdex
added
http
silverwind
changed the title
|
LGTM |
|
Thanks! Landed in c6ae7d0. |
silverwind
pushed a commit
that referenced
this pull request
Feb 27, 2016
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: #5296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2016
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: #5296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Added the lts watch label... |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: #5296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
The description of httpVersionMajor & httpVersionMinor should have same context like httpVersion. PR-URL: #5296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.