src: improve node::Dotenv declarations #52973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const.
nodejs-github-bot
added
c++
anonrig
approved these changes
May 13, 2024
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
May 14, 2024
tniessen
added
dotenv
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3f3226c |
targos
pushed a commit
that referenced
this pull request
May 21, 2024
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. PR-URL: #52973 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. PR-URL: nodejs#52973 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. PR-URL: nodejs#52973 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. PR-URL: #52973 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. PR-URL: #52973 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to explicitly allow copy constructor and copy assignment, and some of these functions should be marked as const. Also remove a branch that appears to serve no purpose.