Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-process-getactivehandles is flaky #5303

Closed
wants to merge 1 commit into from
Closed

test: test-process-getactivehandles is flaky #5303

wants to merge 1 commit into from

Conversation

orangemocha
Copy link
Contributor

Ref: #5302

@orangemocha orangemocha added the test Issues and PRs related to the tests. label Feb 18, 2016
@Trott
Copy link
Member

Trott commented Feb 18, 2016

LGTM

@Trott Trott added arm Issues and PRs related to the ARM platform. dont-land-on-v4.x labels Feb 18, 2016
@Trott
Copy link
Member

Trott commented Feb 18, 2016

Applied the dont-land-on-v4.x label because the test in question does not exist in v4.x and the PR that added it is also labeled dont-land-on-v4.x.

@orangemocha
Copy link
Contributor Author

Will land shortly, earlier than 48 hours as this is a trivial change and it reduces the chances of spurious CI failures.

@orangemocha
Copy link
Contributor Author

https://ci.nodejs.org/job/node-test-pull-request/1703/

@orangemocha
Copy link
Contributor Author

That failed on armv7-wheezy for unrelated reasons.

Failed connect to github.com:443; Connection timed out

Re-trying: https://ci.nodejs.org/job/node-test-pull-request/1704/

orangemocha added a commit that referenced this pull request Feb 19, 2016
@orangemocha
test: test-process-getactivehandles is flaky
c05a330 
Ref: #5302

PR-URL: #5303
Reviewed-By: Rich Trott <rtrott@gmail.com>
@orangemocha
Copy link
Contributor Author

CI is yellow.

Landed in c05a330. Thanks!

rvagg pushed a commit that referenced this pull request Feb 21, 2016
@orangemocha @rvagg
test: test-process-getactivehandles is flaky
d9177e7 
Ref: #5302

PR-URL: #5303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orangemocha @Trott