Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use broader detection for 'help' #53045

Merged
merged 2 commits into from
May 25, 2024

Conversation

RedYetiDev
Copy link
Member

This PR updates the vcbuild.bat to use a broader way to detect help/?

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels May 18, 2024
vcbuild.bat Outdated Show resolved Hide resolved
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53045
✔  Done loading data for nodejs/node/pull/53045
----------------------------------- PR info ------------------------------------
Title      build: use broader detection for 'help' (#53045)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:patch-31 -> nodejs:main
Labels     windows, build, author ready, needs-ci
Commits    2
 - build: use broader detection for 'help'
 - Update vcbuild.bat
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53045
Reviewed-By: Stefan Stojanovic 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53045
Reviewed-By: Stefan Stojanovic 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 May 2024 13:13:35 GMT
   ✔  Approvals: 3
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/53045#pullrequestreview-2068005716
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2073211950
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2078304184
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-23T14:44:20Z: https://ci.nodejs.org/job/node-test-pull-request/59374/
- Querying data for job/node-test-pull-request/59374/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   e818eee5af..0d7b5a938c  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 0d7b5a938c doc: move all TLS-PSK documentation to its section
--------------------------------------------------------------------------------
HEAD is now at 0d7b5a938c doc: move all TLS-PSK documentation to its section
   ✔  Reset to origin/main
- Downloading patch for 53045
From https://github.com/nodejs/node
 * branch                  refs/pull/53045/merge -> FETCH_HEAD
✔  Fetched commits as 0d7b5a938c80..b3c2d70d3fb8
--------------------------------------------------------------------------------
Auto-merging vcbuild.bat
[main 295b9b7964] build: use broader detection for 'help'
 Author: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
 Date: Sat May 18 09:13:15 2024 -0400
 1 file changed, 3 insertions(+), 8 deletions(-)
Auto-merging vcbuild.bat
[main a5f8de17b9] Update vcbuild.bat
 Author: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
 Date: Mon May 20 07:23:23 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
build: use broader detection for 'help'

PR-URL: #53045
Reviewed-By: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD dd6a1c7f9f] build: use broader detection for 'help'
Author: Aviv Keller 38299977+RedYetiDev@users.noreply.github.com
Date: Sat May 18 09:13:15 2024 -0400
1 file changed, 3 insertions(+), 8 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update vcbuild.bat

PR-URL: #53045
Reviewed-By: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD a82bd64c3c] Update vcbuild.bat
Author: Aviv Keller 38299977+RedYetiDev@users.noreply.github.com
Date: Mon May 20 07:23:23 2024 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9237455242

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit d0a7272 into nodejs:main May 25, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d0a7272

targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53045
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants