-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace .substr
with .slice
#53070
Conversation
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not exactly ESLint 9 that introduces the error, but the migration to flat config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just curiosity, why not substring
?
I return the question: why do you think we should use |
Fast-track has been requested by @targos. Please 👍 to approve. |
Commit Queue failed- Loading data for nodejs/node/pull/53070 ✔ Done loading data for nodejs/node/pull/53070 ----------------------------------- PR info ------------------------------------ Title test: replace `.substr` with `.slice` (#53070) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:sub-substr -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: replace `.substr` with `.slice` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 May 2024 11:21:02 GMT ✔ Approvals: 7 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793 ℹ This PR is being fast-tracked ✘ This PR needs to wait 22 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-20T11:26:29Z: https://ci.nodejs.org/job/node-test-pull-request/59311/ - Querying data for job/node-test-pull-request/59311/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9174979544 |
requeued (?) since it was only missing a 👍🏻 on the fast track |
Commit Queue failed- Loading data for nodejs/node/pull/53070 ✔ Done loading data for nodejs/node/pull/53070 ----------------------------------- PR info ------------------------------------ Title test: replace `.substr` with `.slice` (#53070) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:sub-substr -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: replace `.substr` with `.slice` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow Reviewed-By: Tierney Cyren ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow Reviewed-By: Tierney Cyren -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 May 2024 11:21:02 GMT ✔ Approvals: 8 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/53070#pullrequestreview-2069078323 ℹ This PR is being fast-tracked ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-05-21T12:51:22Z: https://ci.nodejs.org/job/node-test-pull-request/59311/ - Querying data for job/node-test-pull-request/59311/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9177998933 |
Landed in 4a54a80 |
This comment was marked as off-topic.
This comment was marked as off-topic.
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: nodejs#53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: nodejs#53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
String.prototype.substr
is deprecated, and using it will raise an error when using ESLint 9+ (#52780).