Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove dependency on wrapper-descriptor-based cpp heap #53086

Closed
wants to merge 18 commits into from

Commits on May 28, 2024

  1. deps: update V8 to 12.7.137

    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3566324 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    512a7b9 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 128

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 12.7.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    47be3ba View commit details
    Browse the repository at this point in the history
  4. deps: always define V8_EXPORT_PRIVATE as no-op

    dllexport introduces issues when compiling with MSVC.
    
    PR-URL: nodejs#47251
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    223de68 View commit details
    Browse the repository at this point in the history
  5. deps: disable V8 concurrent sparkplug compilation

    It introduces process hangs on some platforms because Node.js doesn't
    tear down V8 correctly.
    Disable it while we work on a solution.
    
    Refs: nodejs#47297
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
    PR-URL: nodejs#47450
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a827b0e View commit details
    Browse the repository at this point in the history
  6. deps: avoid compilation error with ASan

    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9b83b8e View commit details
    Browse the repository at this point in the history
  7. deps: remove usage of a C++20 feature from V8

    We are not ready to compile with C++20 support yet.
    This is only a DCHECK that can be removed without affecting the behavior
    of release builds.
    
    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3849d83 View commit details
    Browse the repository at this point in the history
  8. deps: patch V8 to avoid duplicated zlib symbol

    PR-URL: nodejs#49639
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4da65e9 View commit details
    Browse the repository at this point in the history
  9. deps: silence internal V8 deprecation warning

    PR-URL: nodejs#52293
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    35ebfb1 View commit details
    Browse the repository at this point in the history
  10. deps: patch V8 to support compilation with MSVC

    After enabling -std:c++20 on Windows, patch is now much smaller.
    
    PR-URL: nodejs#52465
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    StefanStojanovic authored and targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    38a5e0b View commit details
    Browse the repository at this point in the history
  11. deps: V8: revert CL 5331688

    On Windows debug builds, it is not allowed to dereference empty
    iterators.
    
    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
    PR-URL: nodejs#52465
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9d544d4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9d8823a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8d34ef7 View commit details
    Browse the repository at this point in the history
  14. build: disable ICF for mksnapshot

    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5447267
    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    LeszekSwirski and targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f553d5d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    54ad3e4 View commit details
    Browse the repository at this point in the history
  16. tools: update V8 gypfiles for 12.6

    targos committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a1c9178 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. deps: V8: cherry-pick 300451e869ae

    Original commit message:
    
        src: fix v8-sandbox.h multiline comments
    
        Before it fails to compile with -Werrors=comment because some of
        the `//` comments uses `\` at the end of the line.
    
        Refs: nodejs#53086
    
        Change-Id: I10e5b970cff4a8eda78c305f5649d8bf08d7da3c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5584738
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Commit-Queue: Joyee Cheung <joyee@igalia.com>
        Cr-Commit-Position: refs/heads/main@{#94165}
    
    Refs: v8/v8@300451e
    joyeecheung committed May 30, 2024
    Configuration menu
    Copy the full SHA
    cb18042 View commit details
    Browse the repository at this point in the history
  2. src: remove dependency on wrapper-descriptor-based CppHeap

    As V8 has moved away from wrapper-descriptor-based CppHeap, this
    patch:
    
    1. Create the CppHeap without using wrapper descirptors.
    2. Deprecates node::SetCppgcReference() in favor of
       v8::Object::Wrap() since the wrapper descriptor is no longer
       relevant. It is still kept as a compatibility layer for addons
       that need to also work on Node.js versions without
       v8::Object::Wrap().
    joyeecheung committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6c7c7c5 View commit details
    Browse the repository at this point in the history