test: increase allocation so it fails for the test #53099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: nodejs#53085
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
May 22, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
May 22, 2024
aduh95
approved these changes
May 22, 2024
richardlau
approved these changes
May 22, 2024
marco-ippolito
approved these changes
May 22, 2024
VoltrexKeyva
approved these changes
May 23, 2024
VoltrexKeyva
added
the
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 501546e |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: #53085 PR-URL: #53099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: nodejs#53085 PR-URL: nodejs#53099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: nodejs#53085 PR-URL: nodejs#53099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: #53085 PR-URL: #53099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-) Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime. Fixes: #53085 PR-URL: #53099 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be impossible to allocate 1e10 bytes but with a v8 update this allocation can succeed. This results in 2x10GB allocations and failure to test the failure :-)
Increase allocation to 1e20 bytes, which should fail for some time, returning the test to using only 50MB at runtime.
Fixes: #53085