Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] vm: harden module type checks #53109

Closed
wants to merge 1 commit into from
Closed

[v20.x] vm: harden module type checks #53109

wants to merge 1 commit into from

Commits on Jun 18, 2024

  1. vm: harden module type checks 

    Check if the value returned from user linker function is a null-ish
value.

`validateInternalField` should be preferred when checking `this`
argument to guard against null-ish `this`.

Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com>
PR-URL: nodejs#52162
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    @legendecas @MikeRalphson
    legendecas and MikeRalphson committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5081f84 View commit details
    Browse the repository at this point in the history