Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix wrong function name in example of context.plan() #53140

Merged
merged 1 commit into from
May 26, 2024
Merged

doc: fix wrong function name in example of context.plan() #53140

merged 1 commit into from
May 26, 2024

Conversation

deokjinkim
Copy link
Contributor

t.subtest -> t.test

Refs: #52860

(1) With t.subtest

✖ top level test (2.496498ms)
  TypeError: t.subtest is not a function
      at TestContext.<anonymous> (/home/deokjinkim/oss/node-playground/tr2.js:6:5)
      at Test.runInAsyncScope (node:async_hooks:206:9)
      at Test.run (node:internal/test_runner/test:841:25)
      at Test.processPendingSubtests (node:internal/test_runner/test:550:18)
      at node:internal/test_runner/harness:247:12
      at node:internal/process/task_queues:140:7
      at AsyncResource.runInAsyncScope (node:async_hooks:206:9)
      at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)

(2) With t.test

▶ top level test
  ✔ subtest (1.334498ms)
▶ top level test (3.065425ms)
ℹ tests 2
ℹ suites 0
ℹ pass 2
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 12.305652

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels May 24, 2024
@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 892d360 into nodejs:main May 26, 2024
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 892d360

targos pushed a commit that referenced this pull request Jun 1, 2024
@deokjinkim @targos
doc: fix wrong function name in example of context.plan()
7147c1d 
t.subtest -> t.test

Refs: #52860
PR-URL: #53140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@deokjinkim @sophoniie
doc: fix wrong function name in example of context.plan()
7e20da9 
t.subtest -> t.test

Refs: nodejs#52860
PR-URL: nodejs#53140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@deokjinkim @bmeck
doc: fix wrong function name in example of context.plan()
4d29797 
t.subtest -> t.test

Refs: nodejs#52860
PR-URL: nodejs#53140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@deokjinkim @marco-ippolito
doc: fix wrong function name in example of context.plan()
860a9f2 
t.subtest -> t.test

Refs: #52860
PR-URL: #53140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@deokjinkim @marco-ippolito
doc: fix wrong function name in example of context.plan()
698ea7a 
t.subtest -> t.test

Refs: #52860
PR-URL: #53140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deokjinkim @nodejs-github-bot @jasnell @lpinca @cjihrig @MoLow @atlowChemi