-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: refactor to use min/max of validateInteger
#53148
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:240526_refactor_to_use_minmax_validateInteger
Jun 1, 2024
Merged
test_runner: refactor to use min/max of validateInteger
#53148
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:240526_refactor_to_use_minmax_validateInteger
Jun 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
labels
May 25, 2024
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
May 25, 2024 15:13
27e689b
to
96c85c0
Compare
cjihrig
approved these changes
May 25, 2024
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
May 25, 2024 15:19
96c85c0
to
91c4c7b
Compare
atlowChemi
approved these changes
May 25, 2024
atlowChemi
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
May 25, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 25, 2024
This comment was marked as outdated.
This comment was marked as outdated.
MoLow
approved these changes
May 25, 2024
lpinca
approved these changes
May 27, 2024
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
May 28, 2024 14:07
91c4c7b
to
1044590
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 28, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`.
deokjinkim
force-pushed
the
240526_refactor_to_use_minmax_validateInteger
branch
from
May 29, 2024 13:17
1044590
to
1f4e73c
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 29, 2024
benjamingr
approved these changes
May 30, 2024
deokjinkim
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 1, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 1, 2024
Landed in 88d3952 |
targos
pushed a commit
that referenced
this pull request
Jun 3, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: #53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: nodejs#53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: nodejs#53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: #53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Instead of additional `if` statement, use min/max of `validateInteger` for `shard.index`. PR-URL: #53148 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of additional
if
statement, use min/max ofvalidateInteger
forshard.index
.