Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: refactor to use min/max of validateInteger #53148

Conversation

deokjinkim
Copy link
Contributor

Instead of additional if statement, use min/max of validateInteger for shard.index.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 25, 2024
@deokjinkim deokjinkim force-pushed the 240526_refactor_to_use_minmax_validateInteger branch from 27e689b to 96c85c0 Compare May 25, 2024 15:13
@deokjinkim deokjinkim force-pushed the 240526_refactor_to_use_minmax_validateInteger branch from 96c85c0 to 91c4c7b Compare May 25, 2024 15:19
@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@deokjinkim deokjinkim force-pushed the 240526_refactor_to_use_minmax_validateInteger branch from 91c4c7b to 1044590 Compare May 28, 2024 14:07
@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@nodejs-github-bot
Copy link
Collaborator

Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.
@deokjinkim deokjinkim force-pushed the 240526_refactor_to_use_minmax_validateInteger branch from 1044590 to 1f4e73c Compare May 29, 2024 13:17
@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 88d3952 into nodejs:main Jun 1, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 88d3952

targos pushed a commit that referenced this pull request Jun 3, 2024
Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.

PR-URL: #53148
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.

PR-URL: nodejs#53148
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.

PR-URL: nodejs#53148
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.

PR-URL: #53148
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Instead of additional `if` statement, use min/max of
`validateInteger` for `shard.index`.

PR-URL: #53148
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants