Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include ESM import for HTTP #53165

Merged
merged 3 commits into from
May 30, 2024
Merged

doc: include ESM import for HTTP #53165

merged 3 commits into from
May 30, 2024

Conversation

RedYetiDev
Copy link
Member

This PR changes the instructions on importing the HTTP library to also include ESM instructions.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 26, 2024
mcollina
mcollina approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ronag
ronag reviewed May 27, 2024
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@RedYetiDev @ronag
Update http.md
46f3019 
Co-authored-by: Robert Nagy <ronagy@icloud.com>
aduh95
aduh95 reviewed May 28, 2024
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@RedYetiDev @aduh95
Update doc/api/http.md
c3a9f3c 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@H4ad H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7848528 into nodejs:main May 30, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7848528

targos pushed a commit that referenced this pull request Jun 1, 2024
@RedYetiDev @targos
doc: include ESM import for HTTP
c391923 
PR-URL: #53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@RedYetiDev @eliphazbouye
doc: include ESM import for HTTP
5aea701 
PR-URL: nodejs#53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@RedYetiDev @bmeck
doc: include ESM import for HTTP
34aec1a 
PR-URL: nodejs#53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@RedYetiDev @marco-ippolito
doc: include ESM import for HTTP
8f309b9 
PR-URL: #53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@RedYetiDev @marco-ippolito
doc: include ESM import for HTTP
c143d61 
PR-URL: #53165
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag left review comments

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@H4ad H4ad H4ad approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RedYetiDev @nodejs-github-bot @mcollina @ShogunPanda @ronag @H4ad @aduh95 @marco-ippolito