Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: do not use soon-to-be-deprecated V8 API #53174

Closed
wants to merge 1 commit into from

Commits on May 27, 2024

  1. src: do not use soon-to-be-deprecated V8 API

    V8 announced deprecation of the following methods:
     - v8::Object::SetAccessor(...) in favor of
       v8::Object::SetNativeDataProperty(...),
     - v8::ObjectTemplate::SetNativeDataProperty(...) with AccessControl
       parameter in favor of
       v8::ObjectTemplate::SetNativeDataProperty(...) without AccessControl
       parameter.
    
    See https://crrev.com/c/5006387.
    
    This slightly changes behavior of the following properties:
     - process.debugPort (for worker processes),
     - process.title (for worker processes),
     - process.ppid.
    
    The difference is that they will now behave like a regular writable
    JavaScript data properties - in case setter callback is not provided
    they will be be reconfigured from a native data property (the one
    that calls C++ callbacks upon get/set operations) to a real data
    property (so subsequent reads will no longer trigger C++ getter
    callbacks).
    isheludko authored and targos committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3b148be View commit details
    Browse the repository at this point in the history