Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support python 3.13 #53190

Merged
merged 1 commit into from
May 30, 2024
Merged

build: support python 3.13 #53190

merged 1 commit into from
May 30, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented May 28, 2024 •
edited
Loading

Refs: nodejs/gyp-next#255 (comment)

Python 3.13 is in beta. Add it to the supported Python version list.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 28, 2024
@legendecas legendecas mentioned this pull request May 28, 2024
Merged
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59535/

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 54035ac into nodejs:main May 30, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 54035ac

@legendecas legendecas deleted the build/py-313 branch May 30, 2024 23:24
targos pushed a commit that referenced this pull request Jun 1, 2024
@legendecas @targos
build: support python 3.13
350c733 
PR-URL: #53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@legendecas @EliphazBouye
build: support python 3.13
4153d2d 
PR-URL: nodejs#53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@legendecas @bmeck
build: support python 3.13
64d4b1a 
PR-URL: nodejs#53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@legendecas @marco-ippolito
build: support python 3.13
4351602 
PR-URL: #53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@legendecas @marco-ippolito
build: support python 3.13
eded0c1 
PR-URL: #53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
richardlau pushed a commit that referenced this pull request Nov 22, 2024
@legendecas @richardlau
build: support python 3.13
64a6dcd 
PR-URL: #53190
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@MoLow MoLow MoLow approved these changes

@cclauss cclauss cclauss approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@legendecas @nodejs-github-bot @lpinca @anonrig @cclauss @MoLow @marco-ippolito @VoltrexKeyva