stream: make sure _destroy is called on the tail #53213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Do you think you could make a test? |
|
I will have a look as soon as I have time |
ronag
reviewed
May 30, 2024
ronag
approved these changes
May 30, 2024
|
Good find and fix! |
github-actions
bot
removed
the
request-ci
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
added
the
author ready
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Jun 3, 2024
mcollina
reviewed
Jun 4, 2024
Do you mean avoiding using |
|
@mcollina I had a deeper look, I think I understood what you mean, the issue here is that I have removed the timeouts as they are not needed. Although a quick question - does |
|
Yes, it's more predictable. |
|
since the test has changed, shall we kick start another CI? 👀 |
github-actions
bot
removed
the
request-ci
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53213 ✔ Done loading data for nodejs/node/pull/53213 ----------------------------------- PR info ------------------------------------ Title stream: make sure _destroy is called on the tail (#53213) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-51987 -> nodejs:main Labels author ready, needs-ci Commits 5 - stream: make sure _destroy is called - fixup! add test - Update lib/internal/streams/compose.js - fixup! use common.platformTimeout - fixup! remove slow process as its not needed Committers 2 - jakecastelli <959672929@qq.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! use common.platformTimeout ⚠ - fixup! remove slow process as its not needed ℹ This PR was created on Thu, 30 May 2024 08:05:30 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2089357194 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2091025829 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2094796152 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-08T15:47:51Z: https://ci.nodejs.org/job/node-test-pull-request/59699/ - Querying data for job/node-test-pull-request/59699/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9449666312 |
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53213 ✔ Done loading data for nodejs/node/pull/53213 ----------------------------------- PR info ------------------------------------ Title stream: make sure _destroy is called on the tail (#53213) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-51987 -> nodejs:main Labels author ready, needs-ci Commits 5 - stream: make sure _destroy is called - fixup! add test - Update lib/internal/streams/compose.js - fixup! use common.platformTimeout - fixup! remove slow process as its not needed Committers 2 - jakecastelli <959672929@qq.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53213 Fixes: https://github.com/nodejs/node/issues/51987 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 30 May 2024 08:05:30 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2089357194 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2107988745 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53213#pullrequestreview-2094796152 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-10T13:56:39Z: https://ci.nodejs.org/job/node-test-pull-request/59699/ - Querying data for job/node-test-pull-request/59699/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53213 From https://github.com/nodejs/node * branch refs/pull/53213/merge -> FETCH_HEAD ✔ Fetched commits as 2dea6a4520b8..d8a6156f7cb8 -------------------------------------------------------------------------------- [main 707c3ff394] stream: make sure _destroy is called Author: jakecastelli <959672929@qq.com> Date: Thu May 30 17:21:15 2024 +0930 1 file changed, 3 insertions(+), 3 deletions(-) [main 2dc4090f69] fixup! add test Author: jakecastelli <959672929@qq.com> Date: Thu May 30 22:54:57 2024 +0930 1 file changed, 49 insertions(+) [main 7866fd2a22] Update lib/internal/streams/compose.js Author: jakecastelli <38635403+jakecastelli@users.noreply.github.com> Date: Fri May 31 08:55:59 2024 +0930 1 file changed, 2 insertions(+), 1 deletion(-) [main 008624d2da] fixup! use common.platformTimeout Author: jakecastelli <959672929@qq.com> Date: Tue Jun 4 20:49:49 2024 +0930 1 file changed, 2 insertions(+), 2 deletions(-) [main 5e225afa4d] fixup! remove slow process as its not needed Author: jakecastelli <959672929@qq.com> Date: Tue Jun 4 23:44:27 2024 +0930 1 file changed, 13 insertions(+), 17 deletions(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)https://github.com/nodejs/node/actions/runs/9450518114 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8e6901a |
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53213 Fixes: nodejs#51987 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53213 Fixes: nodejs#51987 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51987 (attempt to).
Please let me know if I am on the right track as I could be missing some important stuff here. If the fix is on the right track I will add a test.
EDIT: I have added a test.