Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove first timer badge #53338

Merged
merged 2 commits into from
Jun 17, 2024
Merged

doc: remove first timer badge #53338

merged 2 commits into from
Jun 17, 2024

Conversation

avivkeller
Copy link
Member

The Github First-Time contributor badge has gone some changes since this image was taken, and I'm sure there will be more changes to it in the future. I don't think it's worth it to store this label as a photo, as the badge can be represented almost the exact same using text.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 4, 2024
@avivkeller
Copy link
Member Author

markup-cropped

Although, if you'd like to keep the badge, I've made an SVG modern version of it.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
doc/contributing/collaborator-guide.md Outdated Show resolved Hide resolved
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 6, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53338
✔  Done loading data for nodejs/node/pull/53338
----------------------------------- PR info ------------------------------------
Title      doc: remove first timer badge (#53338)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:remove- -> nodejs:main
Labels     doc
Commits    2
 - doc: remove first timer badge
 - Update doc/contributing/collaborator-guide.md
Committers 2
 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53338
Reviewed-By: Luigi Pinca 
Reviewed-By: Ulises Gascón 
Reviewed-By: Matteo Collina 
Reviewed-By: Filip Skokan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Marco Ippolito 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53338
Reviewed-By: Luigi Pinca 
Reviewed-By: Ulises Gascón 
Reviewed-By: Matteo Collina 
Reviewed-By: Filip Skokan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Marco Ippolito 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 04 Jun 2024 16:43:35 GMT
   ✔  Approvals: 6
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53338#pullrequestreview-2100112730
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101440281
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101528323
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101538471
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101739951
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2102071302
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9404810010

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 6, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 10, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53338
✔  Done loading data for nodejs/node/pull/53338
----------------------------------- PR info ------------------------------------
Title      doc: remove first timer badge (#53338)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:remove- -> nodejs:main
Labels     doc, commit-queue-squash
Commits    2
 - doc: remove first timer badge
 - Update doc/contributing/collaborator-guide.md
Committers 2
 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53338
Reviewed-By: Luigi Pinca 
Reviewed-By: Ulises Gascón 
Reviewed-By: Matteo Collina 
Reviewed-By: Filip Skokan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53338
Reviewed-By: Luigi Pinca 
Reviewed-By: Ulises Gascón 
Reviewed-By: Matteo Collina 
Reviewed-By: Filip Skokan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 04 Jun 2024 16:43:35 GMT
   ✔  Approvals: 7
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53338#pullrequestreview-2100112730
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101440281
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101528323
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101538471
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101739951
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2102071302
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2104359922
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9455025745

@avivkeller
Copy link
Member Author

avivkeller commented Jun 15, 2024

Last GitHub CI failed

There were some issues with the windows build CI that caused it to fail, can we land manually or rerun the CI if the issues are fixed?

@aduh95 aduh95 merged commit 2333573 into nodejs:main Jun 17, 2024
28 of 29 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jun 17, 2024

Landed in 2333573

targos pushed a commit that referenced this pull request Jun 20, 2024
PR-URL: #53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53338
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.