Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix naming convention of Symbol #53387

Conversation

deokjinkim
Copy link
Contributor

node.js prefix is used for global symbol(Symbol.for). So remove node.js prefix from Symbol usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring

In the Node.js runtime we prefix all our global symbols with `nodejs.`,
e.g. `Symbol.for('nodejs.hello')`.

`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 8, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024
@nodejs-github-bot

This comment was marked as outdated.

lib/internal/event_target.js Outdated Show resolved Hide resolved
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2024
@nodejs-github-bot
Copy link
Collaborator

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit e74dbfb into nodejs:main Jun 10, 2024
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e74dbfb

targos pushed a commit that referenced this pull request Jun 20, 2024
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: nodejs#53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: nodejs#53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. events Issues and PRs related to the events subsystem / EventEmitter. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants