-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: do not crash if the watched file is removed while setting up watch #53452
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Commit Queue failed- Loading data for nodejs/node/pull/53452 ✔ Done loading data for nodejs/node/pull/53452 ----------------------------------- PR info ------------------------------------ Title fs: do not crash if the watched file is removed while setting up watch (#53452) Author Matteo Collina (@mcollina) Branch mcollina:fix-linux-watch -> nodejs:main Labels fs, needs-ci Commits 3 - fs: do not crash if the watched file is removed while setting up watch - fixup - Update test-fs-watch-recursive-linux-parallel-remove.js Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/53452 Reviewed-By: James M Snell Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Chemi Atlow Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53452 Reviewed-By: James M Snell Reviewed-By: Moshe Atlow Reviewed-By: Marco Ippolito Reviewed-By: Chemi Atlow Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Jun 2024 13:42:28 GMT ✔ Approvals: 6 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53452#pullrequestreview-2118488973 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53452#pullrequestreview-2118497686 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53452#pullrequestreview-2118499513 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/53452#pullrequestreview-2118689064 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53452#pullrequestreview-2119052228 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53452#pullrequestreview-2122841230 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-15T05:42:47Z: https://ci.nodejs.org/job/node-test-pull-request/59793/ - Querying data for job/node-test-pull-request/59793/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53452 From https://github.com/nodejs/node * branch refs/pull/53452/merge -> FETCH_HEAD ✔ Fetched commits as 2333573f3907..97c7652629e3 -------------------------------------------------------------------------------- [main d44669170f] fs: do not crash if the watched file is removed while setting up watch Author: Matteo Collina Date: Fri Jun 14 15:41:53 2024 +0200 2 files changed, 44 insertions(+), 5 deletions(-) create mode 100644 test/parallel/test-fs-watch-recursive-linux-parallel-remove.js [main 203dad7f8a] fixup Author: Matteo Collina Date: Fri Jun 14 15:50:44 2024 +0200 2 files changed, 10 insertions(+), 9 deletions(-) [main 60adf9275d] Update test-fs-watch-recursive-linux-parallel-remove.js Author: Matteo Collina Date: Sat Jun 15 07:38:45 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/9548251230 |
Landed in 7430638 |
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #53452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#53452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#53452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #53452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #53452 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Fixes #53350