Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mitigate flaky test-http-agent #5346

Closed
wants to merge 1 commit into from
Closed

test: mitigate flaky test-http-agent #5346

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 21, 2016

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5184

@Trott
test: mitigate flaky test-http-agent
76657c5 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: nodejs#5184
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. lts-watch-v4.x labels Feb 21, 2016
@Trott
Copy link
Member Author

Trott commented Feb 21, 2016

Stress test showing this version of the test is not flaky: https://ci.nodejs.org/job/node-stress-single-test/517/nodes=pi2-raspbian-wheezy/console

Stress test showing the version currently in master is flaky: https://ci.nodejs.org/job/node-stress-single-test/510/nodes=pi2-raspbian-wheezy/console

@Trott
Copy link
Member Author

Trott commented Feb 21, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1711/

@jasnell
Copy link
Member

jasnell commented Feb 21, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 22, 2016

ARM failure on CI is due to a known-flaky that Fishrock123 just fixed. Everything else looks good.

@Trott
Copy link
Member Author

Trott commented Feb 22, 2016

This one is flaking a lot (just got another one this morning). This fix is tiny and easy to undo. And it only affects test code.

So I'm going to go ahead and land it now under the "trivial changes" clause. If this is bending that rule a bit too much in anyone's opinion, let me know and I'll undo the change and/or try to be more conservative in the future.

Trott added a commit to Trott/io.js that referenced this pull request Feb 22, 2016
@Trott
test: mitigate flaky test-http-agent
bbf4621 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: nodejs#5184
PR-URL: nodejs#5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 22, 2016

Landed in bbf4621

@Trott Trott closed this Feb 22, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@Trott @rvagg
test: mitigate flaky test-http-agent
991f82b 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@Trott
test: mitigate flaky test-http-agent
8899016 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Trott
test: mitigate flaky test-http-agent
c86902d 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex mentioned this pull request Apr 9, 2016
Closed
@Trott Trott deleted the try-stuff branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @jasnell @MylesBorins