Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify error handling in net/createServer #5353

Closed
wants to merge 1 commit into from
Closed

doc: clarify error handling in net/createServer #5353

wants to merge 1 commit into from

Conversation

dirceu
Copy link
Contributor

@dirceu dirceu commented Feb 21, 2016

Fixes: #5345

@evanlucas
Copy link
Contributor

LGTM.

/cc @trevnorris

@mscdex mscdex added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Feb 21, 2016
@jasnell
Copy link
Member

jasnell commented Feb 21, 2016

It would be good if the commit log message identified what was clarified a bit more specifically.
Otherwise LGTM

@dirceu
Copy link
Contributor Author

dirceu commented Feb 21, 2016

@jasnell good point. Can you please check the new commit message?

evanlucas
evanlucas reviewed Feb 21, 2016
View reviewed changes
doc/api/net.markdown
server.listen(8124, (err) => {
// 'listening' listener
if (err) throw err;
server.listen(8124, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an error listener here as well.

@dirceu
doc: clarify error handling in net.createServer
ecf740c 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: nodejs#5345
PR-URL: nodejs#5353
@trevnorris
Copy link
Contributor

LGTM. Thanks for looking into this.

@benjamingr
Copy link
Member

LGTM.

evanlucas pushed a commit that referenced this pull request Feb 25, 2016
@dirceu @evanlucas
doc: clarify error handling in net.createServer
581606a 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@evanlucas
Copy link
Contributor

Landed in 581606a. Thanks!

@evanlucas evanlucas closed this Feb 25, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@dirceu @rvagg
doc: clarify error handling in net.createServer
a0c3d5f 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@dirceu @rvagg
doc: clarify error handling in net.createServer
935fd21 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@dirceu
doc: clarify error handling in net.createServer
1d97ce0 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
@dirceu
doc: clarify error handling in net.createServer
b86540d 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@dirceu
doc: clarify error handling in net.createServer
5b9bcea 
Remove indications that an error argument is sent to the `listen()` callback.

Fixes: #5345
PR-URL: #5353
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dirceu @evanlucas @jasnell @trevnorris @benjamingr @mscdex @MylesBorins