Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: zero-initialize data that are copied into the snapshot #53563

Closed
wants to merge 3 commits into from
Closed

src: zero-initialize data that are copied into the snapshot #53563

wants to merge 3 commits into from

Commits on Jun 23, 2024

  1. Revert "src: make sure that memcpy-ed structs in snapshot have no pad… 

    …ding"

This reverts commit 4e58cde.
    @joyeecheung
    joyeecheung committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    5c40956 View commit details
    Browse the repository at this point in the history

  2. src: zero-initialize data that are copied into the snapshot 

    To prevent padding from making the snapshot unreproducible,
zero-initialize the data that are copied into the snapshot
so that the padding copied are all zeros. This is better
than enlarging the enums to align the fields since it doesn't
make the snapshot bigger than necessary, and it removes the
need of using static assertions to ensure alignment.
    @joyeecheung
    joyeecheung committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    af91d7d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. fixup! src: zero-initialize data that are copied into the snapshot

    @joyeecheung
    joyeecheung committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e99f06c View commit details
    Browse the repository at this point in the history