Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rejects readline question promise on abortion #53574

Closed
wants to merge 1 commit into from
Closed

fix: rejects readline question promise on abortion #53574

wants to merge 1 commit into from

Conversation

DanielVenable
Copy link
Contributor

Closes #53497

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Jun 24, 2024
@DanielVenable
Copy link
Contributor Author

I realize this is a breaking change. Anyone know if readline question should always reject when the interface is closed, or only when closed with ctl+C or ctl+D?

@benjamingr
Copy link
Member

or only when closed with ctl+C or ctl+D?

The latter

@DanielVenable DanielVenable deleted the close-readline-question-promise-on-abort branch July 13, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise readline question results in unsettled promise on abortion
3 participants
@DanielVenable @benjamingr @nodejs-github-bot