Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add gn files for deps/nbytes #53685

Closed
wants to merge 1 commit into from
Closed

build: add gn files for deps/nbytes #53685

wants to merge 1 commit into from
+41 −0

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jul 2, 2024

Match the changes of #53507.

@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60091/

@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60133/

zcbenz added a commit that referenced this pull request Jul 7, 2024
@zcbenz
build: add gn files for deps/nbytes
7e80584 
PR-URL: #53685
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@zcbenz
Copy link
Contributor Author

zcbenz commented Jul 7, 2024 •
edited
Loading

Landed in 7e80584

@zcbenz zcbenz closed this Jul 7, 2024
@zcbenz zcbenz deleted the nbytes-gn branch July 7, 2024 05:20
aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@zcbenz @aduh95
build: add gn files for deps/nbytes
88d943c 
PR-URL: #53685
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@zcbenz @aduh95
build: add gn files for deps/nbytes
40032eb 
PR-URL: #53685
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcbenz @nodejs-github-bot @jasnell @anonrig