Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds mjs examples to node:child_process #53788

Closed
wants to merge 2 commits into from

Conversation

mfdebian
Copy link
Contributor

@mfdebian mfdebian commented Jul 9, 2024

I've added mjs examples for the child_process documentation.

I've tested every single example (except for the Windows ones because I don't own a Windows machine ☹️) on my machine and they all work/behave as expected.

I've refrained from making any changes to the cjs examples except for the one in child_process.fork(modulePath[, args][, options]) where the require statement was inside a condition. I took the liberty to put the require statement at the top of the example; If you don't like that I can revert that change.

Thanks in advance for all your hard work, I hope this PRs are helpful 😊 (and not bothersome 🙈)

Best regards ❤️

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jul 9, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Jul 9, 2024

Duplicate of #53616


Sorry! I know you put time and effort into making this, and I know it must be upsetting for that to go unused. Don't worry, every line matters :-)

@RedYetiDev RedYetiDev marked this as a duplicate of #53616 Jul 9, 2024
@RedYetiDev RedYetiDev closed this Jul 9, 2024
@mfdebian
Copy link
Contributor Author

mfdebian commented Jul 18, 2024

@RedYetiDev Thank you! no worries, it me who should've checked before doing it, I'm going to be more precise in investigating before committing to a PR, thanks for the feedback 🫶 it's greatly appreciated!

@mfdebian mfdebian deleted the docs-child-process-mjs branch July 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants