Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-timers.reliability on OS X #5379

Closed
wants to merge 1 commit into from
Closed

test: fix test-timers.reliability on OS X #5379

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 23, 2016

Fix make test-timers so that it works on OS X. (Still won't work everywhere else except some Linux variants.)

/cc @misterdjules @Fishrock123

Fixes: #4404

@Trott Trott added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. lts-watch-v4.x labels Feb 23, 2016
@misterdjules
Copy link

LGTM, thank you @Trott!

@Fishrock123
Copy link
Contributor

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1736/

@Trott
Copy link
Member Author

Trott commented Feb 24, 2016

Looks like Windows and ARM fanned hosts are not up and running in CI yet. Will try again later...

@Trott
Copy link
Member Author

Trott commented Feb 25, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1741/

Trott added a commit to Trott/io.js that referenced this pull request Feb 25, 2016
@Trott
test: fix test-timers.reliability on OS X
8bcb174 
Fixes: nodejs#4404
PR-URL: nodejs#5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 25, 2016

CI is 💚

Landed in 8bcb174

@Trott Trott closed this Feb 25, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@Trott @rvagg
test: fix test-timers.reliability on OS X
53e2548 
Fixes: #4404
PR-URL: #5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@Trott @rvagg
test: fix test-timers.reliability on OS X
ff75023 
Fixes: #4404
PR-URL: #5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@Trott
test: fix test-timers.reliability on OS X
ad3c726 
Fixes: #4404
PR-URL: #5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Trott
test: fix test-timers.reliability on OS X
b4fbe04 
Fixes: #4404
PR-URL: #5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott Trott deleted the timer-test-mac-fix branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @misterdjules @Fishrock123 @MylesBorins