Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix potential segmentation fault in SQLite #53850

Merged
merged 1 commit into from
Jul 16, 2024
Merged

src: fix potential segmentation fault in SQLite #53850

merged 1 commit into from
Jul 16, 2024

Commits on Jul 14, 2024

  1. src: fix potential segmentation fault in SQLite 

    The Local<Value> returned from ColumnToValue() and ColumnNameToValue()
may be empty (if a JavaScript exception is pending), in which case a
segmentation fault may occur at the call sites, which do not check if
the Local<Value> is empty. Fix this bug returning early if an exception
is pending (as indicated by the Local being empty).

In the long term, these functions should return MaybeLocal instead of
Local, but this patch is supposed to be a minimal bug fix only.
    @tniessen
    tniessen committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    b776bbd View commit details
    Browse the repository at this point in the history