src,test: disallow unsafe integer coercion in SQLite #53851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
blocked
nodejs-github-bot
added
c++
cjihrig
approved these changes
Jul 15, 2024
|
BTW nodejs/core-validate-commit#121 will fix the commit lint error |
|
I'll have to rebase this anyway, I can change the commit message while I'm at it if nobody releases a new version of |
tniessen
force-pushed
the
sqlite-dont-coerce-int-silently
branch
from
190f061 to
2af55e1
Compare
Currently, by default (i.e., when use_big_ints_ has not explicitly been set to true), reading a SQLite integer value that is not a safe integer in JavaScript is likely to yield an incorrect number. Instead, err on the side of caution and throw if the stored integer is not a safe integer in JavaScript and if use_big_ints_ has not been set to true.
tniessen
force-pushed
the
sqlite-dont-coerce-int-silently
branch
from
2af55e1 to
1714eda
Compare
tniessen
added
request-ci
tniessen
changed the title
|
#53850 has landed, so this is ready. Rebased and updated the commit message. |
github-actions
bot
removed
the
request-ci
tniessen
added
author ready
|
Landing after 7 days due to lack of reviews. |
tniessen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53851 ✔ Done loading data for nodejs/node/pull/53851 ----------------------------------- PR info ------------------------------------ Title src,test: disallow unsafe integer coercion in SQLite (#53851) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:sqlite-dont-coerce-int-silently -> nodejs:main Labels c++, experimental, author ready, needs-ci, sqlite Commits 1 - src,test: disallow unsafe integer coercion in SQLite Committers 1 - Tobias Nießen <tniessen@tnie.de> PR-URL: https://github.com/nodejs/node/pull/53851 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53851 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - src,test: disallow unsafe integer coercion in SQLite ℹ This PR was created on Sun, 14 Jul 2024 23:26:13 GMT ✔ Approvals: 1 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/53851#pullrequestreview-2176741518 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-17T10:24:04Z: https://ci.nodejs.org/job/node-test-pull-request/60384/ - Querying data for job/node-test-pull-request/60384/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10040445846 |
cjihrig
approved these changes
Jul 22, 2024
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ad0a2db |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
Currently, by default (i.e., when use_big_ints_ has not explicitly been set to true), reading a SQLite integer value that is not a safe integer in JavaScript is likely to yield an incorrect number. Instead, err on the side of caution and throw if the stored integer is not a safe integer in JavaScript and if use_big_ints_ has not been set to true. PR-URL: #53851 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
Currently, by default (i.e., when use_big_ints_ has not explicitly been set to true), reading a SQLite integer value that is not a safe integer in JavaScript is likely to yield an incorrect number. Instead, err on the side of caution and throw if the stored integer is not a safe integer in JavaScript and if use_big_ints_ has not been set to true. PR-URL: #53851 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, by default (i.e., when
use_big_ints_has not explicitly been set to true), reading a SQLite integer value that is not a safe integer in JavaScript is likely to yield an incorrect number.Instead, err on the side of caution and throw if the stored integer is not a safe integer in JavaScript and if
use_big_ints_has not been set to true.Blocked on #53850.