Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move ToNamespacedPath call of webstorage #53875

Merged
merged 1 commit into from
Jul 21, 2024
Merged

src: move ToNamespacedPath call of webstorage #53875

merged 1 commit into from
Jul 21, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 16, 2024

Moves toNamespacedPath call of Storage to C++

@anonrig anonrig requested a review from cjihrig July 16, 2024 20:15
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 16, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig force-pushed the webstorage-tonamespacedpath branch from 7690b03 to 1f97b39 Compare July 19, 2024 15:09
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig force-pushed the webstorage-tonamespacedpath branch from 1f97b39 to 86ccf35 Compare July 19, 2024 15:12
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60495/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1fb23f1 into nodejs:main Jul 21, 2024
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1fb23f1

targos pushed a commit that referenced this pull request Jul 28, 2024
@anonrig @targos
src: move ToNamespacedPath call of webstorage
c5f3ece 
PR-URL: #53875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@anonrig @RafaelGSS
src: move ToNamespacedPath call of webstorage
04bb677 
PR-URL: #53875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig Awaiting requested review from cjihrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @jasnell @addaleax @targos