-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor webstorage implementation #53876
Conversation
8af37ce
to
bb81c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the tests will pass with these changes, but LGTM if they do pass.
As I suspected, the tests appear to be failing. The inputs to these APIs do not need to be strings, but must be able to be converted to strings. |
TIL. So, apparently |
bb81c4e
to
e53f1ad
Compare
Landed in 05b7bf0 |
PR-URL: #53876 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
I couldn't find a good way to split them into multiple pull-requests.