Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add workflow to ensure README lists are in sync with gh teams #53901

Merged
merged 1 commit into from
Aug 6, 2024
Merged

tools: add workflow to ensure README lists are in sync with gh teams #53901

merged 1 commit into from
Aug 6, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 17, 2024 •
edited
Loading

The goal is to not let commit-queue merge PRs that move folks to emeritus (or TSC regular members) without ensuring the GitHub teams have been updated.

Because team membership is not public, it will only work for PR from the bot (which has access to the GH_USER_TOKEN secret). For PRs from forks, it will skip the membership check.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Jul 17, 2024

Hum crap the GH teams are not visible from unauthenticated users

@RedYetiDev
Copy link
Member

Hum crap the GH teams are not visible from unauthenticated users

You could have it run on pull_request_target, only get the README from the PR, checkout the base, and then run the linter?

RedYetiDev
RedYetiDev reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC sparse-checkout will ONLY checkout the given files, so maybe it can be used?

.github/workflows/linters-readme.yml Outdated Show resolved Hide resolved
.github/workflows/linters-readme.yml Outdated Show resolved Hide resolved
@aduh95 aduh95 mentioned this pull request Jul 31, 2024
Merged
@aduh95 aduh95 force-pushed the verify-team-members-readme branch from f8be2d4 to c9d3e8c Compare August 6, 2024 10:34
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 6, 2024

@nodejs/tsc can I get some reviews? I believe that would help us get on top of following up with offboarding tasks.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit b47aa70 into nodejs:main Aug 6, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b47aa70

@aduh95 aduh95 deleted the verify-team-members-readme branch August 7, 2024 16:58
targos pushed a commit that referenced this pull request Aug 14, 2024
@aduh95 @targos
tools: add workflow to ensure README lists are in sync with gh teams
3835131 
PR-URL: #53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
targos pushed a commit that referenced this pull request Sep 21, 2024
@aduh95 @targos
tools: add workflow to ensure README lists are in sync with gh teams
6dea5ae 
PR-URL: #53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos
Copy link
Member

targos commented Sep 25, 2024

Should we skip this workflow on release branches? I just pushed a commit to v20.x-staging and it failed because there is a new collaborator that's not in the readme on that branch: https://github.com/nodejs/node/actions/runs/11040434575/job/30668416255?pr=55022

@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Sep 25, 2024
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 25, 2024

Sounds good, I'll make a PR. I recommend dropping this from the v20.x-staging branch, not having it is very unlikely to cause any conflict.

@aduh95 aduh95 mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @RedYetiDev @targos @anonrig