-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: start using ncrypto for CSPRNG calls #53984
Conversation
Review requested:
|
4df80ae
to
6fd9b19
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FWIW, this partially undoes @bnoordhuis's attempt at making this more difficult to misuse (see https://github.com/nodejs-private/node-private/pull/346#discussion_r967795383 if you have access). |
I never really agreed that that made any real difference one way or the other but if folks feel strongly about it I can retain that. |
Landed in c112b4b |
PR-URL: #53984 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #53984 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
No description provided.