Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-api: add property keys benchmark #54012

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions benchmark/napi/property_keys/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
build/
108 changes: 108 additions & 0 deletions benchmark/napi/property_keys/binding.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
#include <node_api.h>
#include <stdio.h>
#include <stdlib.h>

#define NODE_API_CALL(call) \
do { \
napi_status status = call; \
if (status != napi_ok) { \
fprintf(stderr, #call " failed: %d\n", status); \
abort(); \
} \
} while (0)

#define ABORT_IF_FALSE(condition) \
if (!(condition)) { \
fprintf(stderr, #condition " failed\n"); \
abort(); \
}

static napi_value Runner(napi_env env,
napi_callback_info info,
napi_value property_key) {
napi_value argv[2], undefined, js_array_length, start, end;
size_t argc = 2;
napi_valuetype val_type = napi_undefined;
bool is_array = false;
uint32_t array_length = 0;
napi_value* native_array;

// Validate params and retrieve start and end function.
NODE_API_CALL(napi_get_cb_info(env, info, &argc, argv, NULL, NULL));
ABORT_IF_FALSE(argc == 2);
NODE_API_CALL(napi_typeof(env, argv[0], &val_type));
ABORT_IF_FALSE(val_type == napi_object);
NODE_API_CALL(napi_is_array(env, argv[1], &is_array));
ABORT_IF_FALSE(is_array);
NODE_API_CALL(napi_get_array_length(env, argv[1], &array_length));
NODE_API_CALL(napi_get_named_property(env, argv[0], "start", &start));
NODE_API_CALL(napi_typeof(env, start, &val_type));
ABORT_IF_FALSE(val_type == napi_function);
NODE_API_CALL(napi_get_named_property(env, argv[0], "end", &end));
NODE_API_CALL(napi_typeof(env, end, &val_type));
ABORT_IF_FALSE(val_type == napi_function);

NODE_API_CALL(napi_get_undefined(env, &undefined));
NODE_API_CALL(napi_create_uint32(env, array_length, &js_array_length));

// Copy objects into a native array.
native_array = malloc(array_length * sizeof(*native_array));
for (uint32_t idx = 0; idx < array_length; idx++) {
NODE_API_CALL(napi_get_element(env, argv[1], idx, &native_array[idx]));
}

// Start the benchmark.
napi_call_function(env, argv[0], start, 0, NULL, NULL);

for (uint32_t idx = 0; idx < array_length; idx++) {
NODE_API_CALL(
napi_set_property(env, native_array[idx], property_key, undefined));
}

// Conclude the benchmark.
NODE_API_CALL(
napi_call_function(env, argv[0], end, 1, &js_array_length, NULL));

free(native_array);

return undefined;
}

static napi_value RunPropertyKey(napi_env env, napi_callback_info info) {
napi_value property_key;
NODE_API_CALL(node_api_create_property_key_utf16(
env, "prop", NAPI_AUTO_LENGTH, &property_key));
return Runner(env, info, property_key);
}

static napi_value RunNormalString(napi_env env, napi_callback_info info) {
napi_value property_key;
NODE_API_CALL(
napi_create_string_utf16(env, "prop", NAPI_AUTO_LENGTH, &property_key));
return Runner(env, info, property_key);
}

NAPI_MODULE_INIT() {
napi_property_descriptor props[] = {
{"RunPropertyKey",
NULL,
RunPropertyKey,
NULL,
NULL,
NULL,
napi_writable | napi_configurable | napi_enumerable,
NULL},
{"RunNormalString",
NULL,
RunNormalString,
NULL,
NULL,
NULL,
napi_writable | napi_configurable | napi_enumerable,
NULL},
};

NODE_API_CALL(napi_define_properties(
env, exports, sizeof(props) / sizeof(*props), props));
return exports;
}
9 changes: 9 additions & 0 deletions benchmark/napi/property_keys/binding.gyp
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
'targets': [
{
'target_name': 'binding',
'sources': [ 'binding.c' ],
'defines': [ 'NAPI_EXPERIMENTAL' ],
}
]
}
15 changes: 15 additions & 0 deletions benchmark/napi/property_keys/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';

const common = require('../../common.js');

const binding = require(`./build/${common.buildType}/binding`);

const bench = common.createBenchmark(main, {
n: [5e6],
implem: ['RunPropertyKey', 'RunNormalString'],
});

function main({ n, implem }) {
const objs = Array(n).fill(null).map((item) => new Object());
binding[implem](bench, objs);
}
Loading