Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,permission: support Buffer to permission.has #54104

Merged
merged 3 commits into from
Aug 3, 2024
Merged

lib,permission: support Buffer to permission.has #54104

merged 3 commits into from
Aug 3, 2024

Conversation

RafaelGSS
Copy link
Member

Fixes: #54100

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (01cf9bc) to head (96d00cd).
Report is 35 commits behind head on main.

Files Patch % Lines
lib/internal/process/permission.js 37.50% 5 Missing ⚠️
lib/fs.js 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54104      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.01%     
==========================================
  Files         643      643              
  Lines      181583   181588       +5     
  Branches    34886    34892       +6     
==========================================
- Hits       158114   158103      -11     
- Misses      16751    16758       +7     
- Partials     6718     6727       +9
Files Coverage Δ
lib/fs.js 93.26% <0.00%> (-0.06%) ⬇️
lib/internal/process/permission.js 69.44% <37.50%> (-7.23%) ⬇️

... and 35 files with indirect coverage changes

@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. permission Issues and PRs related to the Permission Model labels Jul 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60736/

mertcanaltin
mertcanaltin approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60768/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60776/

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60797/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60803/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60812/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60832/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60834/

@RafaelGSS RafaelGSS mentioned this pull request Aug 2, 2024
Closed
@RafaelGSS
Copy link
Member Author

Failures are related to nodejs/build#3848

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60837/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2024
@nodejs-github-bot nodejs-github-bot merged commit 358ff74 into nodejs:main Aug 3, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 358ff74

targos pushed a commit that referenced this pull request Aug 14, 2024
@RafaelGSS @targos
lib,permission: support Buffer to permission.has
8c9a4ae 
PR-URL: #54104
Fixes: #54100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental Permissions: Checks from fs functions that accept Buffers fail with TypeError
5 participants
@RafaelGSS @nodejs-github-bot @anonrig @marco-ippolito @mertcanaltin