test: update wpt test for streams #54129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
daeyeon
reviewed
Jul 31, 2024
daeyeon
reviewed
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54129 +/- ##
=======================================
Coverage 87.07% 87.08%
=======================================
Files 643 643
Lines 181581 181576 -5
Branches 34893 34896 +3
=======================================
+ Hits 158118 158125 +7
+ Misses 16742 16730 -12
Partials 6721 6721 |
|
@daeyeon |
daeyeon
reviewed
Jul 31, 2024
| "readable-streams/from.any.js": { | ||
| "fail": { | ||
| "expected": [ | ||
| "ReadableStream.from ignores a null @@asyncIterator" |
There was a problem hiding this comment.
Do we need to fix this in a follow-up PR?
There was a problem hiding this comment.
@MattiasBuelens I think we might need to address this issue. It seems like some basic error handling might be necessary. I'm also open to contributing to a follow-up PR to help resolve this.
daeyeon
approved these changes
Aug 1, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
daeyeon
added
author ready
aduh95
approved these changes
Aug 6, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1bcdba2 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54129 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the web platform tests for the streams.