-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: run after hooks even if test is aborted #54151
Conversation
If a test is run, but aborted, any after hooks should still be run, as they may need to perform cleanup.
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54151 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 643 643
Lines 181580 181574 -6
Branches 34894 34887 -7
=======================================
+ Hits 158103 158110 +7
+ Misses 16749 16747 -2
+ Partials 6728 6717 -11
|
Seen on the most recent CI run on Windows. Linking to #53617 just in case. |
rerun failed here
may relate to nodejs/build#3848, will re-request the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Landed in 67f7137 |
If a test is run, but aborted, any after hooks should still be run, as they may need to perform cleanup. PR-URL: #54151 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
If a test is run, but aborted, any after hooks should still be run, as they may need to perform cleanup.