inspector: provide detailed network information to fix devtools frontend errors

[cola119]

ref #53593 (comment)

This PR addresses and resolves specific errors occurring in the ChromeDevTools frontend, as reported at issues.chromium.org.

The error being fixed are as follows:

NetworkManager.ts:758 Uncaught TypeError: Cannot read properties of undefined (reading 'headers')
    at NetworkDispatcher.responseReceived (NetworkManager.ts:758:71)
    at DispatcherManager.dispatch (InspectorBackend.ts:1114:11)
    at Target.dispatch (InspectorBackend.ts:566:16)
    at SessionRouter.onMessage (InspectorBackend.ts:447:22)
    at WebSocketConnection.#socket.onmessage (Connections.ts:90:24)

These errors occur because Node.js doesn't provide the necessary debug information (such as request/response headers and content type) to the frontend during network inspection. Without this information, the Chrome DevTools frontend cannot properly handle and display network requests, leading to the aforementioned errors. To resolve the issue, the change in this PR ensure that Node.js supplies the required debugging information to the frontend. Specifically,

• Adding request and response headers.
• Adding response information.
• Providing the resource type for network responses.

[codecov]

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (e7edcf3) to head (e02aaa7).
Report is 31 commits behind head on main.

Files	Patch %	Lines
src/inspector/network_agent.cc	92.10%	2 Missing and 1 partial ⚠️
lib/internal/inspector_network_tracking.js	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54156      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.01%     
==========================================
  Files         643      643              
  Lines      181582   181652      +70     
  Branches    34891    34910      +19     
==========================================
+ Hits       158111   158157      +46     
- Misses      16751    16767      +16     
- Partials     6720     6728       +8     

Files	Coverage Δ
lib/internal/inspector_network_tracking.js	95.74% <96.87%> (+0.50%)	⬆️
src/inspector/network_agent.cc	93.97% <92.10%> (-2.03%)	⬇️

... and 35 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60791/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60792/

[legendecas]

Overall LGTM % one comment.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60826/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60831/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60840/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/54156
✔  Done loading data for nodejs/node/pull/54156
----------------------------------- PR info ------------------------------------
Title      inspector: provide detailed network information to fix devtools frontend errors (#54156)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cola119:fix-ni-frontend-error -> nodejs:main
Labels     c++, inspector, author ready, commit-queue-squash
Commits    4
 - inspector: provide detailed info to fix DevTools frontend errors
 - inspector: support `Network.Response.statusText` property
 - inspector: delete unused declarations in header file for cleanup
 - inspector: convert a header object to a simple string dictionary
Committers 1
 - cola119 <kohei.ueno119@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54156
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54156
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 01 Aug 2024 06:29:33 GMT
   ✔  Approvals: 1
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/54156#pullrequestreview-2215047386
   ✘  This PR needs to wait 76 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-08-02T22:33:18Z: https://ci.nodejs.org/job/node-test-pull-request/60840/
- Querying data for job/node-test-pull-request/60840/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10241284324

[legendecas]

/cc @nodejs/inspector would you mind taking a look at this?

[nodejs-github-bot]

Landed in 3616ace