Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x] Backport "module: fix strip-types interaction with detect-module" #54211

Closed
wants to merge 1 commit into from
Closed

[v22.x] Backport "module: fix strip-types interaction with detect-module" #54211

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Aug 5, 2024 •
edited
Loading

This is a backport of #54164

This backport adds the imply of --experimental-detect-module to --experimental-strip-types
https://github.com/nodejs/node/pull/54211/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8R803

cc @joyeecheung

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Aug 5, 2024
@marco-ippolito marco-ippolito added needs-ci PRs that need a full CI run. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 5, 2024
@marco-ippolito marco-ippolito mentioned this pull request Aug 5, 2024
Merged
@marco-ippolito marco-ippolito added lib / src Issues and PRs related to general changes in the lib or src directory. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60878/

mcollina
mcollina approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60881/

@marco-ippolito
module: fix strip-types interaction with detect-module
01631f3 
PR-URL: nodejs#54164
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito marco-ippolito force-pushed the backport/strip-types-imply branch from 23d5d60 to 01631f3 Compare August 5, 2024 14:19
marco-ippolito added a commit that referenced this pull request Aug 5, 2024
@marco-ippolito
module: fix strip-types interaction with detect-module
c20e841 
PR-URL: #54164
Backport-PR-URL: #54211
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito
Copy link
Member Author

Landed in c20e841

@marco-ippolito marco-ippolito deleted the backport/strip-types-imply branch August 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@khaosdoctor khaosdoctor khaosdoctor approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marco-ippolito @nodejs-github-bot @mcollina @khaosdoctor @joyeecheung @RafaelGSS