deps: fix GN build warning in ncrypto #54222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Aug 6, 2024
anonrig
added
the
author ready
zcbenz
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/54222 ✔ Done loading data for nodejs/node/pull/54222 ----------------------------------- PR info ------------------------------------ Title deps: fix GN build warning in ncrypto (#54222) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:ncrypto-warning -> nodejs:main Labels author ready, needs-ci, dependencies Commits 1 - deps: fix GN build warning in ncrypto Committers 1 - Cheng <git@zcbenz.com> PR-URL: https://github.com/nodejs/node/pull/54222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 06 Aug 2024 04:20:36 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54222#pullrequestreview-2221357752 ✘ This PR needs to wait 76 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-06T04:26:59Z: https://ci.nodejs.org/job/node-test-pull-request/60897/ - Querying data for job/node-test-pull-request/60897/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10327059036 |
nodejs-github-bot
added
the
commit-queue-failed
jasnell
approved these changes
Aug 11, 2024
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4dae01b |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.